skip_neutral_temps only if SMB's somehow disabled#1452
Open
mountrcg wants to merge 2 commits intoopenaps:devfrom
Open
skip_neutral_temps only if SMB's somehow disabled#1452mountrcg wants to merge 2 commits intoopenaps:devfrom
mountrcg wants to merge 2 commits intoopenaps:devfrom
Conversation
| // console.error(profile.skip_neutral_temps, rT.deliverAt.getMinutes()); | ||
| if ( profile.skip_neutral_temps && rT.deliverAt.getMinutes() >= 55 ) { | ||
| rT.reason += "; Canceling temp at " + rT.deliverAt.getMinutes() + "m past the hour. "; | ||
| if ( profile.skip_neutral_temps && !enableSMB && rT.deliverAt.getMinutes() >= 55 ) { |
Contributor
There was a problem hiding this comment.
Do we want to print some sort of “ignoring skip_neutral_temps because SMB is enabled” message if enableSMB?
Contributor
Author
There was a problem hiding this comment.
done that, but only for the log, no rT.reason output - thinking too much clutter
2023-06-27 07:56:17.653895+0200 DEV: JavaScript log: maxDelta threshold for BG-Jump to allow SMB's set to: 30%
2023-06-27 07:56:17.654444+0200 DEV: JavaScript log: BG projected to remain above 100 for 240minutes
2023-06-27 07:56:17.654994+0200 DEV: JavaScript log: naive_eventualBG: 120, bgUndershoot: -50, zeroTempDuration: 240, zeroTempEffect: 351, carbsReq: -94
2023-06-27 07:56:17.655532+0200 DEV: JavaScript log: 4min before turn of the hour, but SMB's are enabled - no skipping neutral temps
2023-06-27 07:56:17.656076+0200 DEV: JavaScript log: SMB max range extended from default by factor 3
2023-06-27 07:56:17.656608+0200 DEV: JavaScript log: profile.maxSMBBasalMinutes:,120,profile.current_basal:,2.05
2023-06-27 07:56:17.657135+0200 DEV: JavaScript log: SMB Delivery Ratio increased from default 0.5 to 0.68
2023-06-27 07:56:17.657669+0200 DEV: JavaScript log: naive_eventualBG 120, 0m 0U/h temp needed; last bolus 1139.9m ago; maxBolus: 12.3
This was referenced Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1451 so that one doesnt miss out on any necessary SMB's if
skip_neutral_tempsis enabled